Python Forum
Feedback on my first Python module
Thread Rating:
  • 1 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Feedback on my first Python module
#11
(Jun-16-2018, 05:37 PM)snippsat Wrote: Some use of string formatting but could be more,not so nice + ' ' +.
f-string makes it a lot nicer,that will of course make it 3.6 only.
if that's no problem then use f-string.

Thanks for the perspective. Looks more neat. I agree. I like to keep the module python 2.7 friendly, since I'll be using it on systems where some may not have 3+ installed.

Thanks to everyone for their comments and ideas. <3 I have implemented almost all of them into the code. I have gone ahead and improved the module by categorizing functions into classes. I'ld appreciate a second look since much has changed. I have followed a guide to add a Linux server to an AD domain controller and used my module to realize that in a script.
If you'ld be so kind to look and let me know if the way the module and the script plays together looks fine or if I'm doing something super noobish.

I can tell that it does work on my Ubuntu test servers.

The module is here: https://github.com/CodeRaker/automation/...toolbox.py
The AD joiner script is here: https://github.com/CodeRaker/administrat...ad-join.py

Thanks, I really appreciate all your inputs.
Reply
#12
(Jun-20-2018, 08:55 PM)CodeRaker Wrote: I like to keep the module python 2.7 friendly, since I'll be using it on systems where some may not have 3+ installed.

You might look at the format method of strings. It's 2.7 friendly and in the direction of an f-string.
Craig "Ichabod" O'Brien - xenomind.com
I wish you happiness.
Recommended Tutorials: BBCode, functions, classes, text adventures
Reply


Possibly Related Threads…
Thread Author Replies Views Last Post
  My First Python Script. Feedback Sought. malonn 5 3,794 Jun-29-2018, 03:49 PM
Last Post: Zombie_Programming
  Feedback on module GamePatrol 1 2,446 Mar-06-2018, 07:40 AM
Last Post: Gribouillis

Forum Jump:

User Panel Messages

Announcements
Announcement #1 8/1/2020
Announcement #2 8/2/2020
Announcement #3 8/6/2020