Python Forum
class definition and problem with a method - Printable Version

+- Python Forum (https://python-forum.io)
+-- Forum: Python Coding (https://python-forum.io/forum-7.html)
+--- Forum: General Coding Help (https://python-forum.io/forum-8.html)
+--- Thread: class definition and problem with a method (/thread-41879.html)

class definition and problem with a method - HerrAyas - Apr-01-2024

Hi all,
I am trying to understand the correct usage of classes and methods (== functions inside the class definition?)
Below you see a class "Punkt", which refers to points in a 2D-plane with an x and y coordinate.
Simple enough, I try to add two points p1 and p2
First try: p1+p2 --> "unsupported operand type" (understood)
2nd try: Write a function "add" wich manipulates the .x and .y properties of the object "Punkt"
3rd try: Implement the function in the class definition (is that called "method"?) Here's the code:
class Punkt():
    def __init__(self, x = 99, y = 99):      #ALWAYS give default-values!
        self.x = x
        self.y = y

    def __str__(self):
        return f'( {self.x} | {self.y} )'
    
    def add(self, p1, p2):
        self = Punkt()             #WHY? WITH this line, every result is 99/99 
        self.x = p1.x + p2.x
        self.y = p1.y + p2.y
        return(self)
    
p1 = Punkt()                    #without __init (x and y defaults) here's an error
p1.x = 17                       #without __init (complete) no one has a problem
p1.y = 12

p2 = Punkt(-9,-4)

p3 = Punkt()
p3.add(p1,p2)                
print(f"Punkt 1: {p1}")
print(f"Punkt 2: {p2}")
print(f"Punkt 3: {p3}")
In line 10 you see me trying to initiate an object "Punkt" called "self", so I have something to work with.
But if I do so, the output of "print Punkt 3 {p3}" is always the default value of 99/99.
I thought, self = Punkt() calls an object called "self", which is a "Punkt()" and has the default values of x=99 and y=99.
After that, (line 11/12), I manipulate the self.x and self.y and return the new, edited values.

I tried much and over and over - just accidentially put a # in front of line 10 "self = Punkt()" and BOOM - it worked.

It would be very nice, if somebody could explain this to me (in simple words - kind of new to python :)

Greetings,
MrAyas

Output WITH line 10 active
Output:
Punkt 1: ( 17 | 12 )
Punkt 2: ( -9 | -4 )
Punkt 3: ( 99 | 99 )
Output WITHOUT line 10
Output:
Punkt 1: ( 17 | 12 )
Punkt 2: ( -9 | -4 )
Punkt 3: ( 8 | 8 )


RE: class definition and problem with a method - deanhystad - Apr-01-2024

Remember that variables are not objects in Python, they are references to objects. "p3 = Punkt()" creates a variable named "p3" and assigns it the newly created Punkt() object. When you call p3.add(p1, p1), self is a variable inside the method/function Punkt.add(). Initially it references the same object referenced by p3. When you assign a new value to self inside of add() (self = Punkt()), self no longer refers to the same object as p3. Changes made to self will not affect p3. Your function returns the new Punkt object, but you ignore the return value.

Your code would work if you wrote: p3 = p3.add(p1, p2). This reassigns p3 to refer to the new object that was created in add(). Another way to fix this is what you did by accident. Don't reassign self so it continues to refer to the same object as p3. Changes made to self are not changes made to p3, because they both reference the same object (changes are actually made to the object, not to self or p3).

But that is not what you want to do. You want to override the + operator.
class Punkt():
    def __init__(self, x=0, y=0):
        self.x = x
        self.y = y

    def __str__(self):
        return f'( {self.x} | {self.y} )'

    def __add__(self, p2):
        """Override the + operator."""
        return Punkt(self.x + p2.x, self.y + p2.y)


p1 = Punkt(17, 12)
p2 = Punkt(-9,-4)
p3 = p1 + p2
print(f"Punkt 3: {p3}")
Output:
Punkt 3: ( 8 | 8 )


RE: class definition and problem with a method - HerrAyas - Apr-01-2024

thank you very much!