Python Forum
How can you make it simpler?
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
How can you make it simpler?
#1
Hi. I'm a newbie. I'm trying to make a Python program that can give me a random 4 digit number without digit repetition but it is too long and very confusing. Can you make it simpler?


def fourdigit(x):
    import random
    num2 = random.randrange(0, 10)
    num3 = random.randrange(0, 10)
    num4 = random.randrange(0, 10)
    if num2 == x:
        while num2 == x:
            num2 = random.randrange(0, 10)
        if num3 == x:
            while num3 == x:
                num3 = random.randrange(0, 10)
            if num3 == num2:
                while num3 == num2:
                    num3 = random.randrange(0, 10)
                if num4 == x:
                    while num4 == x:
                        num4 = random.randrange(0, 10)
                    if num4 == num2:
                        while num4 == num2:
                            num4 = random.randrange(0, 10)
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                    else:
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                else:
                    if num4 == num2:
                        while num4 == num2:
                            num4 = random.randrange(0, 10)
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                    else:
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)

            else:
                if num4 == x:
                    while num4 == x:
                        num4 = random.randrange(0, 10)
                    if num4 == num2:
                        while num4 == num2:
                            num4 = random.randrange(0, 10)
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                    else:
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                else:
                    if num4 == num2:
                        while num4 == num2:
                            num4 = random.randrange(0, 10)
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                    else:
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
        else:
            if num3 == num2:
                while num3 == num2:
                    num3 = random.randrange(0, 10)
                if num4 == x:
                    while num4 == x:
                        num4 = random.randrange(0, 10)
                    if num4 == num2:
                        while num4 == num2:
                            num4 = random.randrange(0, 10)
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                    else:
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                else:
                    if num4 == num2:
                        while num4 == num2:
                            num4 = random.randrange(0, 10)
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                    else:
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
            else:
                if num4 == x:
                    while num4 == x:
                        num4 = random.randrange(0, 10)
                    if num4 == num2:
                        while num4 == num2:
                            num4 = random.randrange(0, 10)
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                    else:
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                else:
                    if num4 == num2:
                        while num4 == num2:
                            num4 = random.randrange(0, 10)
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                    else:
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
    else:
        if num3 == x:
            while num3 == x:
                num3 = random.randrange(0, 10)
            if num3 == num2:
                while num3 == num2:
                    num3 = random.randrange(0, 10)
                if num4 == x:
                    while num4 == x:
                        num4 = random.randrange(0, 10)
                    if num4 == num2:
                        while num4 == num2:
                            num4 = random.randrange(0, 10)
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                    else:
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                else:
                    if num4 == num2:
                        while num4 == num2:
                            num4 = random.randrange(0, 10)
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                    else:
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
            else:
                if num4 == x:
                    while num4 == x:
                        num4 = random.randrange(0, 10)
                    if num4 == num2:
                        while num4 == num2:
                            num4 = random.randrange(0, 10)
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                    else:
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                else:
                    if num4 == num2:
                        while num4 == num2:
                            num4 = random.randrange(0, 10)
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                    else:
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
        else:
            if num3 == num2:
                while num3 == num2:
                    num3 = random.randrange(0, 10)
                if num4 == x:
                    while num4 == x:
                        num4 = random.randrange(0, 10)
                    if num4 == num2:
                        while num4 == num2:
                            num4 = random.randrange(0, 10)
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                    else:
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                else:
                    if num4 == num2:
                        while num4 == num2:
                            num4 = random.randrange(0, 10)
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                    else:
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
            else:
                if num4 == x:
                    while num4 == x:
                        num4 = random.randrange(0, 10)
                    if num4 == num2:
                        while num4 == num2:
                            num4 = random.randrange(0, 10)
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                    else:
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                else:
                    if num4 == num2:
                        while num4 == num2:
                            num4 = random.randrange(0, 10)
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
                    else:
                        if num4 == num3:
                            while num4 == num3:
                                num4 = random.randrange(0, 10)
                            print(x, num2, num3, num4)
                        else:
                            print(x, num2, num3, num4)
Reply


Messages In This Thread
How can you make it simpler? - by bitcoin10mil - Aug-22-2020, 07:21 PM
RE: How can you make it simpler? - by bitcoin10mil - Aug-22-2020, 08:00 PM
RE: How can you make it simpler? - by bowlofred - Aug-22-2020, 08:31 PM
RE: How can you make it simpler? - by snippsat - Aug-22-2020, 08:38 PM

Possibly Related Threads…
Thread Author Replies Views Last Post
  i am looking for a simpler tokenizer Skaperen 7 3,604 Jul-29-2019, 05:31 PM
Last Post: Skaperen
  How to make this simpler. leoahum 7 3,804 Mar-11-2019, 01:57 PM
Last Post: leoahum

Forum Jump:

User Panel Messages

Announcements
Announcement #1 8/1/2020
Announcement #2 8/2/2020
Announcement #3 8/6/2020