Python Forum
Feedback on my first Python module
Thread Rating:
  • 1 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Feedback on my first Python module
#7
some random thoughts:

1. do not do if verbose == True:. verbose is already True or False, so just do if verbose:
2. All this
if action == 'restart':
    run_command('systemctl restart ' + service, systemctl_verbose)
    if verbose == True:
        print('[V] Restarting service: ' + service)
if action == 'start':
    run_command('systemctl start ' + service, systemctl_verbose)
    if verbose == True:
        print('[V] Starting service: ' + service)
if action == 'stop':
    run_command('systemctl stop ' + service, systemctl_verbose)
    if verbose == True:
        print('[V] Stopping service: ' + service)
if action == 'reload':
    run_command('systemctl reload ' + service, systemctl_verbose)
    if verbose == True:
        print('[V] Reloading service: ' + service)
could be just

run_command('systemctl {} {}'.format(action, service), systemctl_verbose)
if verbose:
    print('[V] {} service: {}'.format(action.capitalize(), service))

3. this
with open(path) as infile:
    with open(path + '.new', 'w') as outfile:
can be on one line, to reduce indentation levels
with open(path) as infile, open(path + '.new', 'w') as outfile:
If you can't explain it to a six year old, you don't understand it yourself, Albert Einstein
How to Ask Questions The Smart Way: link and another link
Create MCV example
Debug small programs

Reply


Messages In This Thread
Feedback on my first Python module - by CodeRaker - Jun-16-2018, 12:07 PM
RE: Feedback on my first Python module - by Larz60+ - Jun-16-2018, 12:55 PM
RE: Feedback on my first Python module - by buran - Jun-16-2018, 03:29 PM
RE: Feedback on my first Python module - by buran - Jun-16-2018, 03:52 PM
RE: Feedback on my first Python module - by buran - Jun-16-2018, 05:17 PM

Possibly Related Threads…
Thread Author Replies Views Last Post
  My First Python Script. Feedback Sought. malonn 5 3,869 Jun-29-2018, 03:49 PM
Last Post: Zombie_Programming
  Feedback on module GamePatrol 1 2,500 Mar-06-2018, 07:40 AM
Last Post: Gribouillis

Forum Jump:

User Panel Messages

Announcements
Announcement #1 8/1/2020
Announcement #2 8/2/2020
Announcement #3 8/6/2020