Mar-22-2018, 03:13 AM
Could you explain what you mean when you say you hit a break wall?
From looking at it, the entry point isn't entirely clear, the structure seems... unstructured (the class for interacting with the remote server prints a great deal, so it can't be reused in a GUI version), I see at least one use of a global variable (with strange documentation about it that I couldn't grok), lots of swallowing exceptions (which can make debugging very difficult), comments that look like they should be docstrings, opened files without context managers, single-letter variable names (e.g. "f" where "filename" might be better), commented out code... Lots of stuff that I would flag during code review.
From a git perspective: The commit messages could be more descriptive. I find it weird that there are zip files; I would use branches or tags for versioning (and I think Github might have other support for releases, but I've never used it) rather than checking in binary files.
I know this might seem like a lot, so I'd focus on one or two things at a time if you're interested in any of this feedback.
From looking at it, the entry point isn't entirely clear, the structure seems... unstructured (the class for interacting with the remote server prints a great deal, so it can't be reused in a GUI version), I see at least one use of a global variable (with strange documentation about it that I couldn't grok), lots of swallowing exceptions (which can make debugging very difficult), comments that look like they should be docstrings, opened files without context managers, single-letter variable names (e.g. "f" where "filename" might be better), commented out code... Lots of stuff that I would flag during code review.
From a git perspective: The commit messages could be more descriptive. I find it weird that there are zip files; I would use branches or tags for versioning (and I think Github might have other support for releases, but I've never used it) rather than checking in binary files.
I know this might seem like a lot, so I'd focus on one or two things at a time if you're interested in any of this feedback.